Sentry Supabase Integration #2913
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2913 +/- ##
==========================================
- Coverage 88.47% 88.35% -0.13%
==========================================
Files 291 291
Lines 9917 9917
==========================================
- Hits 8774 8762 -12
- Misses 1143 1155 +12 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 75284dc | 512.39 ms | 530.87 ms | 18.48 ms |
| e45c0e1 | 447.29 ms | 558.33 ms | 111.04 ms |
| fd88186 | 422.07 ms | 469.10 ms | 47.03 ms |
| 819c1e7 | 449.80 ms | 442.98 ms | -6.82 ms |
| 2cf9161 | 454.12 ms | 512.67 ms | 58.55 ms |
| c1e775e | 482.36 ms | 608.98 ms | 126.62 ms |
| 6e7d494 | 397.35 ms | 378.91 ms | -18.43 ms |
| 79f6b41 | 469.66 ms | 525.90 ms | 56.24 ms |
| 5a95d04 | 378.92 ms | 364.33 ms | -14.59 ms |
| 793f4dc | 462.68 ms | 544.21 ms | 81.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 75284dc | 13.93 MiB | 14.93 MiB | 1.00 MiB |
| e45c0e1 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| fd88186 | 13.93 MiB | 15.00 MiB | 1.06 MiB |
| 819c1e7 | 13.93 MiB | 15.00 MiB | 1.06 MiB |
| 2cf9161 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| c1e775e | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| 6e7d494 | 13.93 MiB | 15.06 MiB | 1.13 MiB |
| 79f6b41 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 5a95d04 | 13.93 MiB | 15.06 MiB | 1.13 MiB |
| 793f4dc | 6.54 MiB | 7.69 MiB | 1.15 MiB |
Previous results on branch: feat/supabase
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8bd9497 | 470.21 ms | 524.26 ms | 54.05 ms |
| 0a08454 | 515.10 ms | 634.67 ms | 119.57 ms |
| 22c24e6 | 483.94 ms | 485.42 ms | 1.48 ms |
| e4d1bf6 | 499.64 ms | 528.47 ms | 28.82 ms |
| 30c089b | 471.71 ms | 522.65 ms | 50.94 ms |
| 1476f86 | 477.10 ms | 480.87 ms | 3.77 ms |
| 5454931 | 447.86 ms | 439.08 ms | -8.78 ms |
| 34b0923 | 509.55 ms | 590.18 ms | 80.62 ms |
| 2db18e6 | 470.42 ms | 473.86 ms | 3.43 ms |
| ecfbb1d | 479.15 ms | 537.30 ms | 58.15 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8bd9497 | 6.44 MiB | 7.43 MiB | 1013.21 KiB |
| 0a08454 | 6.44 MiB | 7.43 MiB | 1013.22 KiB |
| 22c24e6 | 13.93 MiB | 15.06 MiB | 1.13 MiB |
| e4d1bf6 | 6.44 MiB | 7.44 MiB | 1017.53 KiB |
| 30c089b | 6.44 MiB | 7.43 MiB | 1010.46 KiB |
| 1476f86 | 13.93 MiB | 14.93 MiB | 1.00 MiB |
| 5454931 | 13.93 MiB | 15.00 MiB | 1.06 MiB |
| 34b0923 | 6.44 MiB | 7.43 MiB | 1013.10 KiB |
| 2db18e6 | 13.93 MiB | 14.93 MiB | 1.00 MiB |
| ecfbb1d | 6.54 MiB | 7.71 MiB | 1.17 MiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6ad8fc4 | 1263.70 ms | 1266.06 ms | 2.36 ms |
| c8596a6 | 1234.11 ms | 1241.19 ms | 7.08 ms |
| c0dde50 | 1268.90 ms | 1275.61 ms | 6.71 ms |
| 2cf9161 | 1248.33 ms | 1266.55 ms | 18.22 ms |
| c1e775e | 1263.08 ms | 1275.32 ms | 12.24 ms |
| bfabaf2 | 1251.72 ms | 1253.38 ms | 1.67 ms |
| 7b21e8b | 1256.79 ms | 1267.12 ms | 10.33 ms |
| d0aa4b6 | 1268.23 ms | 1268.39 ms | 0.15 ms |
| 54acf91 | 1257.65 ms | 1277.96 ms | 20.31 ms |
| 192b44c | 1269.08 ms | 1275.52 ms | 6.44 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6ad8fc4 | 5.53 MiB | 6.01 MiB | 487.65 KiB |
| c8596a6 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| c0dde50 | 5.53 MiB | 6.01 MiB | 488.14 KiB |
| 2cf9161 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| c1e775e | 20.70 MiB | 22.46 MiB | 1.75 MiB |
| bfabaf2 | 5.53 MiB | 6.01 MiB | 487.95 KiB |
| 7b21e8b | 5.53 MiB | 6.00 MiB | 479.96 KiB |
| d0aa4b6 | 5.53 MiB | 6.02 MiB | 502.04 KiB |
| 54acf91 | 20.70 MiB | 22.46 MiB | 1.75 MiB |
| 192b44c | 5.53 MiB | 5.96 MiB | 444.33 KiB |
Previous results on branch: feat/supabase
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 34b0923 | 1269.29 ms | 1275.88 ms | 6.59 ms |
| 22c24e6 | 1254.75 ms | 1265.22 ms | 10.47 ms |
| 5454931 | 1266.92 ms | 1270.20 ms | 3.29 ms |
| b0f288d | 1261.51 ms | 1264.02 ms | 2.51 ms |
| 0a08454 | 1265.15 ms | 1283.18 ms | 18.04 ms |
| 2c3bf29 | 1248.09 ms | 1259.79 ms | 11.70 ms |
| f8ec07b | 1259.06 ms | 1273.22 ms | 14.16 ms |
| de422e0 | 1245.98 ms | 1249.29 ms | 3.31 ms |
| e4d1bf6 | 1249.16 ms | 1267.12 ms | 17.96 ms |
| 5e3ca91 | 1263.90 ms | 1277.43 ms | 13.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 34b0923 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
| 22c24e6 | 5.53 MiB | 6.00 MiB | 485.11 KiB |
| 5454931 | 5.53 MiB | 6.00 MiB | 479.95 KiB |
| b0f288d | 5.53 MiB | 6.00 MiB | 479.95 KiB |
| 0a08454 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
| 2c3bf29 | 5.53 MiB | 6.01 MiB | 488.12 KiB |
| f8ec07b | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| de422e0 | 5.53 MiB | 6.01 MiB | 488.14 KiB |
| e4d1bf6 | 8.43 MiB | 10.00 MiB | 1.56 MiB |
| 5e3ca91 | 8.43 MiB | 10.00 MiB | 1.56 MiB |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
@buenaflor Issues should be addressed now. |
buenaflor
left a comment
buenaflor
left a comment
There was a problem hiding this comment.
looks good! only a few comments left
| - name: supabase | ||
| working-directory: ./packages/supabase | ||
| run: lakos . -i "{test/**,example/**}" | dot -Tsvg -o class-diagram.svg | ||
|
|
There was a problem hiding this comment.
honestly I keep forgetting this diagram exists 😓
There was a problem hiding this comment.
TBH, we could think about removing this, no? My hunch is nobody uses it and it's outdated anyway. We could leave it as a dev option so we can generate it locally to get an overview, but remove the checked in files. WDYT?
|
cloudflare has an outage so lots of tests are failing now that depend on external downloads |
|
@buenaflor Last week I created a sample project with Flutter + Subase as an evaluation. I wan't to try this out before we merge. |
|
sounds good, looks good to me now let me know if you thinks its ready |
|
@buenaflor Ok, looking good with the sample app. The error client is being called and breadcrumbs created. 
Only thing i saw that the hub does not have a span, so we can't create one. Dunno if this is supposed to be like that? We have the same logic in other integrations. 
|
do you have a running transaction with |
📜 Description
Supabase instrumentation for database operations (no auth instrumentation)
💡 Motivation and Context
Closes #2727
💚 How did you test it?
Unit tests.
📝 Checklist
sendDefaultPiiis enabled